Try making SuperSocket.Kestrel support Detach #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerryjiang
reviewed
Dec 8, 2024
| @@ -412,5 +423,16 @@ protected void OnError(string message, Exception e = null) | |||
| else | |||
| Logger?.LogError(message); | |||
| } | |||
|
|
|||
| protected void SupplyEnd() | |||
There was a problem hiding this comment.
These methods are not required by other derived classes, so probably you can leave them in KestrelPopeConnection.
kerryjiang
requested changes
Dec 8, 2024
| if (Options.ReadAsDemand) | ||
| { | ||
| var defaultObjectPipe = new DefaultObjectPipeWithSupplyControl<TPackageInfo>(); | ||
| _supplyController = defaultObjectPipe; |
There was a problem hiding this comment.
It seems you don't have to do this. Because the packagePipe will be pass to KestrelPipeConnection eventually.
| protected override Task StartInputPipeTask<TPackageInfo>(IObjectPipe<TPackageInfo> packagePipe, | ||
| CancellationToken cancellationToken) | ||
| { | ||
| cancellationToken.Register(SupplyEnd); |
There was a problem hiding this comment.
packagePipe can be read here, so yo don't need to define a field for packagePipe in the base class.
|
Take a look at this branch: |
kerryjiang
approved these changes
Dec 11, 2024
| UpdateLastActiveTime(); | ||
| } | ||
|
|
There was a problem hiding this comment.
It seems we cannot do supply control for kestrel, because the data flow network => read pipeline is out of our control. This place only can control the read from read pipeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.